-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.47.0 #15894
Conversation
…io-block [Gutenberg] Hide audio block on free sites
This reverts commit c855d99.
You can trigger an installable build for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me so far. Hopefully the testing build finishes soon.
Based on #15752 (review), we'll need to swap from a git commit to a tag after we merge wordpress-mobile/gutenberg-mobile#3155.
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
…grate_release_1.46.1_to_1.47.0 # Conflicts: # Podfile # Podfile.lock
…ress-mobile/WordPress-iOS into gutenberg/integrate_release_1.46.1_to_1.47.0
…elease_1.46.1_to_1.47.0 Integrate gutenberg-mobile release 1.46.1 to 1.47.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We just need to change the Podfile ref from commit to tag before merging.
Podfile
Outdated
@@ -153,7 +153,7 @@ target 'WordPress' do | |||
## Gutenberg (React Native) | |||
## ===================== | |||
## | |||
gutenberg :tag => 'v1.47.0-alpha2' | |||
gutenberg :commit => '7f75b334f402ff36ac154274b728c25533dcb3a4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to merging, we'll need to create a v1.47.0
in gutenberg-mobile
, reference that here, and install the pods.
…nto gutenberg/integrate_release_1.47.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 I've found some discrepancies in the release notes related to the changes included the beta fixes.
Relocate changes that were made in a beta fix and reside in the previous 16.7 release.
…nto gutenberg/integrate_release_1.47.0
Description
This PR incorporates the 1.47.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3155
Release Submission Checklist