Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.47.0 #15894

Merged
merged 28 commits into from
Feb 19, 2021

Conversation

antonis
Copy link

@antonis antonis commented Feb 16, 2021

Description

This PR incorporates the 1.47.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3155
Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to `RELEASE-NOTES.txt` if necessary.

@antonis antonis added the Gutenberg Editing and display of Gutenberg blocks. label Feb 16, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@dcalhoun dcalhoun marked this pull request as ready for review February 16, 2021 15:09
@dcalhoun dcalhoun added this to the 16.8 milestone Feb 16, 2021
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me so far. Hopefully the testing build finishes soon.

Based on #15752 (review), we'll need to swap from a git commit to a tag after we merge wordpress-mobile/gutenberg-mobile#3155.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to change the Podfile ref from commit to tag before merging.

Podfile Outdated
@@ -153,7 +153,7 @@ target 'WordPress' do
## Gutenberg (React Native)
## =====================
##
gutenberg :tag => 'v1.47.0-alpha2'
gutenberg :commit => '7f75b334f402ff36ac154274b728c25533dcb3a4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to merging, we'll need to create a v1.47.0 in gutenberg-mobile, reference that here, and install the pods.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I've found some discrepancies in the release notes related to the changes included the beta fixes.

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Relocate changes that were made in a beta fix and reside in the previous
16.7 release.
@dcalhoun dcalhoun merged commit cc7ae42 into develop Feb 19, 2021
@dcalhoun dcalhoun deleted the gutenberg/integrate_release_1.47.0 branch February 19, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants